Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scripts section #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shivankurchavan
Copy link

@shivankurchavan shivankurchavan commented Jun 28, 2024

created scripts section under CLI

Summary by CodeRabbit

  • Documentation
    • Added new guide scripts.md for using npm scripts with Stencil applications.
    • Updated docker compose commands to docker-compose in the getting started guide.
    • Added cli/scripts to the CLI section in the sidebar for easier navigation.

Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stencil-docs ✅ Ready (Inspect) Visit Preview Jun 28, 2024 5:42am

Copy link

coderabbitai bot commented Jun 28, 2024

Walkthrough

This update enhances the documentation for managing a Stencil application by adding a new guide on using npm scripts and adjusting docker-compose commands. Additionally, it updates the sidebar configuration to include the new CLI scripts documentation.

Changes

Files Change Summary
docs/cli/scripts.md Introduced a new file providing guidance on managing the build and execution process of a Stencil application using npm scripts.
docs/home.md Updated docker compose commands to docker-compose in the getting started guide for Stencil.
sidebars.js Added 'cli/scripts' to the CLI section.

Poem

In scripts, we trust and npm we lean,
Building Stencil apps, so crisp and clean,
Docker-compose updated, commands refined,
With a sidebar now, all well-aligned.
The code, it flows, like rivers clear,
Stencil's future, bright and near. 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1faba13 and 12d8c8c.

Files selected for processing (3)
  • docs/cli/scripts.md (1 hunks)
  • docs/home.md (1 hunks)
  • sidebars.js (1 hunks)
Files skipped from review due to trivial changes (1)
  • sidebars.js
Additional context used
LanguageTool
docs/home.md

[uncategorized] ~20-~20: You might be missing the article “the” here.
Context: ...services efficiently. ## Key Features Stencil comes with a set of key features to emp...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


[uncategorized] ~35-~35: Possible missing article found.
Context: ...ng Started To quickly get started with Stencil, follow these simple steps: 1. Clone t...

(AI_HYDRA_LEO_MISSING_A)

Markdownlint
docs/cli/scripts.md

23-23: null
Dollar signs used before commands without showing output

(MD014, commands-show-output)


35-35: null
Dollar signs used before commands without showing output

(MD014, commands-show-output)


45-45: null
Dollar signs used before commands without showing output

(MD014, commands-show-output)


54-54: null
Files should end with a single newline character

(MD047, single-trailing-newline)

Additional comments not posted (3)
docs/home.md (2)

58-59: Update Docker commands to use docker-compose.

It's good to see the update from docker compose to docker-compose for consistency and compatibility. Ensure that all Docker documentation within the project reflects this change.


65-65: Ensure proper use of Docker commands.

The updated command for checking Docker logs is a crucial step for troubleshooting. Please verify that the command works as expected in all environments where this documentation will be used.

docs/cli/scripts.md (1)

30-38: Improve documentation on npm build command.

The build instructions are straightforward. However, the note on keeping dependencies in-check could be expanded with examples or links to resources on how to update and manage npm packages effectively.
[REFACTOR_SUGGESTion]

Tools
Markdownlint

35-35: null
Dollar signs used before commands without showing output

(MD014, commands-show-output)

Comment on lines +20 to +26
To link a local package, use the following npm command:

```bash
$ npm link
```

This is useful when you are developing multiple packages locally and want to test them together.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify npm link usage.

The section on linking local packages is clear. Consider adding an example to demonstrate how npm link can be used in a practical scenario, which will enhance understanding for new developers.

Tools
Markdownlint

23-23: null
Dollar signs used before commands without showing output

(MD014, commands-show-output)


Running the above commands at the OS command level ensures that the build and execute processes are managed as project dependencies in `package.json`. This way, all members of your organization can be assured of running the same version of the commands. By following this **recommended** usage, you can fully customize the behavior of these scripts via their options and/or customize the `tsc` compiler options files (e.g., `tsconfig.json`) as needed.

For most developers/teams, it is recommended to utilize the package scripts for building and executing their Nest projects.</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a newline at the end of the file.

Files should end with a single newline character to comply with POSIX standards and facilitate proper processing by Unix/Linux utilities.

+ \n
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
For most developers/teams, it is recommended to utilize the package scripts for building and executing their Nest projects.</p>
For most developers/teams, it is recommended to utilize the package scripts for building and executing their Nest projects.</p>
Tools
Markdownlint

54-54: null
Files should end with a single newline character

(MD047, single-trailing-newline)

Comment on lines +42 to +48
To start your Stencil application, use the following npm command:

```bash
$ npm run start
```

This command will execute the compiled application.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standardize command documentation.

For consistency, avoid using the dollar sign before commands unless you are showing output. This adheres to Markdownlint suggestions and improves readability.

- $ npm run start
+ npm run start
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
To start your Stencil application, use the following npm command:
```bash
$ npm run start
```
This command will execute the compiled application.
To start your Stencil application, use the following npm command:
```bash
npm run start
```
This command will execute the compiled application.
Tools
Markdownlint

45-45: null
Dollar signs used before commands without showing output

(MD014, commands-show-output)

@techsavvyash techsavvyash linked an issue Jul 2, 2024 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] CLI docs
1 participant