-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: scripts section #20
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis update enhances the documentation for managing a Stencil application by adding a new guide on using npm scripts and adjusting docker-compose commands. Additionally, it updates the sidebar configuration to include the new CLI scripts documentation. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- docs/cli/scripts.md (1 hunks)
- docs/home.md (1 hunks)
- sidebars.js (1 hunks)
Files skipped from review due to trivial changes (1)
- sidebars.js
Additional context used
LanguageTool
docs/home.md
[uncategorized] ~20-~20: You might be missing the article “the” here.
Context: ...services efficiently. ## Key Features Stencil comes with a set of key features to emp...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~35-~35: Possible missing article found.
Context: ...ng Started To quickly get started with Stencil, follow these simple steps: 1. Clone t...(AI_HYDRA_LEO_MISSING_A)
Markdownlint
docs/cli/scripts.md
23-23: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
35-35: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
45-45: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
54-54: null
Files should end with a single newline character(MD047, single-trailing-newline)
Additional comments not posted (3)
docs/home.md (2)
58-59
: Update Docker commands to usedocker-compose
.It's good to see the update from
docker compose
todocker-compose
for consistency and compatibility. Ensure that all Docker documentation within the project reflects this change.
65-65
: Ensure proper use of Docker commands.The updated command for checking Docker logs is a crucial step for troubleshooting. Please verify that the command works as expected in all environments where this documentation will be used.
docs/cli/scripts.md (1)
30-38
: Improve documentation on npm build command.The build instructions are straightforward. However, the note on keeping dependencies in-check could be expanded with examples or links to resources on how to update and manage npm packages effectively.
[REFACTOR_SUGGESTion]Tools
Markdownlint
35-35: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
To link a local package, use the following npm command: | ||
|
||
```bash | ||
$ npm link | ||
``` | ||
|
||
This is useful when you are developing multiple packages locally and want to test them together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify npm link usage.
The section on linking local packages is clear. Consider adding an example to demonstrate how npm link
can be used in a practical scenario, which will enhance understanding for new developers.
Tools
Markdownlint
23-23: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
|
||
Running the above commands at the OS command level ensures that the build and execute processes are managed as project dependencies in `package.json`. This way, all members of your organization can be assured of running the same version of the commands. By following this **recommended** usage, you can fully customize the behavior of these scripts via their options and/or customize the `tsc` compiler options files (e.g., `tsconfig.json`) as needed. | ||
|
||
For most developers/teams, it is recommended to utilize the package scripts for building and executing their Nest projects.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a newline at the end of the file.
Files should end with a single newline character to comply with POSIX standards and facilitate proper processing by Unix/Linux utilities.
+ \n
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
For most developers/teams, it is recommended to utilize the package scripts for building and executing their Nest projects.</p> | |
For most developers/teams, it is recommended to utilize the package scripts for building and executing their Nest projects.</p> | |
Tools
Markdownlint
54-54: null
Files should end with a single newline character(MD047, single-trailing-newline)
To start your Stencil application, use the following npm command: | ||
|
||
```bash | ||
$ npm run start | ||
``` | ||
|
||
This command will execute the compiled application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Standardize command documentation.
For consistency, avoid using the dollar sign before commands unless you are showing output. This adheres to Markdownlint suggestions and improves readability.
- $ npm run start
+ npm run start
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
To start your Stencil application, use the following npm command: | |
```bash | |
$ npm run start | |
``` | |
This command will execute the compiled application. | |
To start your Stencil application, use the following npm command: | |
```bash | |
npm run start | |
``` | |
This command will execute the compiled application. |
Tools
Markdownlint
45-45: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
created scripts section under CLI
Summary by CodeRabbit
scripts.md
for using npm scripts with Stencil applications.docker compose
commands todocker-compose
in the getting started guide.cli/scripts
to the CLI section in the sidebar for easier navigation.